Remove redundant variable already set by hpc-launcher#21
Merged
michaelmckinsey1 merged 2 commits intoLBANN:mainfrom Mar 5, 2026
Merged
Remove redundant variable already set by hpc-launcher#21michaelmckinsey1 merged 2 commits intoLBANN:mainfrom
michaelmckinsey1 merged 2 commits intoLBANN:mainfrom
Conversation
michaelmckinsey1
changed the title
PatrickRMiles
approved these changes
Mar 5, 2026
| fi | ||
| done No newline at end of file | ||
| done | ||
| cd - |
Collaborator
There was a problem hiding this comment.
is this cd - necessary?
Collaborator
Author
There was a problem hiding this comment.
It gets the user back to the directory they were in after running the script. otherwise they will end up in .venvs/scaffoldvenv-tuo/lib/python3.11/site-packages/torch/lib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NCCL_NET=libfabricis already set correctly by HPC-launcher. tested -NCCL INFO Using network Libfabric